Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_extractor work with MockImagingInterface #1076

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Make get_extractor work with MockImagingInterface #1076

merged 5 commits into from
Sep 12, 2024

Conversation

h-mayorquin
Copy link
Collaborator

These changes are necessary so the get_extractor method works with MockImagingInterface

neuroconv/src/neuroconv/baseextractorinterface.py

Lines 21 to 31 in 9a88658

@classmethod
def get_extractor(cls):
if cls.Extractor is not None:
return cls.Extractor
extractor_module = get_package(package_name=cls.ExtractorModuleName)
extractor = getattr(
extractor_module,
cls.ExtractorName or cls.__name__.replace("Interface", "Extractor"),
)
cls.Extractor = extractor
return extractor

@h-mayorquin h-mayorquin self-assigned this Sep 11, 2024
@h-mayorquin h-mayorquin mentioned this pull request Sep 11, 2024
Merged
@h-mayorquin h-mayorquin changed the title Make get_extractor work with mock imaging Make get_extractor work with MockImagingInterface Sep 11, 2024
pauladkisson
pauladkisson requested changes Sep 11, 2024
View reviewed changes
Copy link
Member

@pauladkisson pauladkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog but otherwise looks good. Makes much more sense to me in a separate PR too, thx.

@h-mayorquin
Copy link
Collaborator Author

Added changelog.

@pauladkisson pauladkisson merged commit 2611825 into main Sep 12, 2024
35 checks passed
@pauladkisson pauladkisson deleted the make_get_extractor_work_with_mock_imaging branch September 12, 2024 00:11
@codecov Codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (81a022d) to head (ca374cb).
Report is 64 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1076      +/-   ##
==========================================
+ Coverage   90.32%   90.36%   +0.04%     
==========================================
  Files         129      129              
  Lines        7996     7999       +3     
==========================================
+ Hits         7222     7228       +6     
+ Misses        774      771       -3
Flag Coverage Δ
unittests 90.36% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/neuroconv/tools/testing/mock_interfaces.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauladkisson pauladkisson pauladkisson approved these changes

Assignees

@h-mayorquin h-mayorquin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-mayorquin @pauladkisson